Update login page #2736
Merged
Update login page #2736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust size of the logo at the login page to be more visible and to better fit into the page. The old logo was smaller. The new one is more a square.
Use the useGmp hook insted of the withGmp HOC. Using hooks is much easier to understand then the HOCs.
Pass also all other params for the react class component to the parent class.
Without the width the panel shrinks a lot and gets to small.
Render the panel as a flexbox.
Add a powered by Greenbone logo to the bottom of the login form.
Open Greenbone website when clicking on the powered by Greenbone logo.
Use same wording as our cloud frontent.
Use hooks for easier understanding of the LoginForm. It is a very basic form component and is more readable a as function component using hooks.
y0urself
reviewed
Feb 24, 2021
y0urself
previously approved these changes
Feb 24, 2021
The height of the product image has changed with the new image.
Use a more expressive name for the component.
y0urself
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Update login page to use same terms and new logo.
Why:
Every GSM gets an newly designed logo therefore GSA gets a fitting logo too. To have a common login page for GSA and the cloud product we should use the same terms too.
How:
Checklist: