Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-select greenbone sensor as default scanner type #2867

Merged
merged 3 commits into from Apr 23, 2021
Merged

Pre-select greenbone sensor as default scanner type #2867

merged 3 commits into from Apr 23, 2021

Conversation

bjoernricks
Copy link
Member

@bjoernricks bjoernricks commented Apr 22, 2021

What:

For creating a scanner use the greenbone sensor as default scanner type
when opening the dialog.

Why:

Customers may be confused by adding a OSP scanner because current sensors are based on OSP too.

How:

Checklist:

  • Tests
  • CHANGELOG Entry
  • Labels for ports to other branches

For creating a scanner use the greenbone sensor as default scanner type
when opening the dialog.
@bjoernricks bjoernricks added the port-to-main Use mergifiy to port PR to master label Apr 22, 2021
@bjoernricks bjoernricks requested a review from a team April 22, 2021 14:05
@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #2867 (42310dc) into gsa-21.04 (74a1fd3) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-21.04    #2867      +/-   ##
=============================================
- Coverage      53.83%   53.83%   -0.01%     
=============================================
  Files           1075     1075              
  Lines          26226    26232       +6     
  Branches        7491     7499       +8     
=============================================
+ Hits           14118    14121       +3     
- Misses         10993    10995       +2     
- Partials        1115     1116       +1     
Impacted Files Coverage Δ
gsa/src/web/pages/nvts/solution.js 22.22% <0.00%> (-11.12%) ⬇️
gsa/src/web/pages/targets/details.js 10.00% <ø> (ø)
gsa/src/web/pages/scanners/dialog.js 70.31% <66.66%> (+0.47%) ⬆️
gsa/src/gmp/models/certbund.js 100.00% <100.00%> (ø)
gsa/src/gmp/models/cpe.js 94.73% <100.00%> (-0.27%) ⬇️
gsa/src/gmp/models/cve.js 98.21% <100.00%> (-0.04%) ⬇️
gsa/src/gmp/models/dfncert.js 100.00% <100.00%> (ø)
gsa/src/gmp/models/nvt.js 99.00% <100.00%> (+0.07%) ⬆️
gsa/src/gmp/models/ovaldef.js 94.54% <100.00%> (-0.10%) ⬇️
gsa/src/web/pages/tasks/actions.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3794fa4...42310dc. Read the comment docs.

@saberlynx saberlynx changed the title Pre-select greenbone sensor als default scanner type Pre-select greenbone sensor as default scanner type Apr 23, 2021
@bjoernricks bjoernricks merged commit 99f5929 into greenbone:gsa-21.04 Apr 23, 2021
@bjoernricks bjoernricks deleted the scanner-dialog-greenbone-sensor branch April 23, 2021 10:14
This was referenced May 6, 2021
swaterkamp added a commit that referenced this pull request May 18, 2021
Pre-select greenbone sensor as default scanner type (backport #2867)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port-to-main Use mergifiy to port PR to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants