Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting Radius secret key in dialog #2915

Merged
merged 2 commits into from May 17, 2021
Merged

Fix setting Radius secret key in dialog #2915

merged 2 commits into from May 17, 2021

Conversation

swaterkamp
Copy link
Member

What:
Backport from #2891

Use value of dialog internal state for secret key in radius dialog.

Why:
The value was fixed and unchangeable.

How:
Manual tests

Checklist:

  • Tests, due to older dependencies, the tests will remain as given, instead of updating them to use userEvent() as done in the newer branches
  • CHANGELOG Entry
  • [N/A] Labels for ports to other branches

@swaterkamp swaterkamp self-assigned this May 17, 2021
@swaterkamp swaterkamp requested a review from a team as a code owner May 17, 2021 12:47
@swaterkamp swaterkamp enabled auto-merge May 17, 2021 12:53
@swaterkamp swaterkamp merged commit 037864b into greenbone:gsa-20.08 May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahd93 sarahd93 sarahd93 approved these changes

@saberlynx saberlynx Awaiting requested review from saberlynx

Assignees

@swaterkamp swaterkamp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@swaterkamp @sarahd93