Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting whether to include related resources in new permissions #2931

Merged
merged 2 commits into from May 21, 2021

Conversation

swaterkamp
Copy link
Member

What:
Use correct change handler for the Select to set whether to include related resources when creating new permissions in a resource.

Why:
Only the default to include related resources was sent to gvmd. The value of the dropdown could not be changed.

How:
Manual tests whether the value was changeable and if the correct values was sent.

Checklist:

  • [N/A] Tests
  • CHANGELOG Entry
  • Labels for ports to other branches

@swaterkamp swaterkamp added port-to-main Use mergifiy to port PR to master port-to-stable Use mergifiy to port PR to stable port-to-21.10 labels May 21, 2021
@swaterkamp swaterkamp self-assigned this May 21, 2021
@swaterkamp swaterkamp requested a review from a team as a code owner May 21, 2021 10:21
@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #2931 (e8396ed) into gsa-20.08 (2f34292) will increase coverage by 0.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-20.08    #2931      +/-   ##
=============================================
+ Coverage      53.06%   53.74%   +0.67%     
=============================================
  Files           1072     1072              
  Lines          25900    25908       +8     
  Branches        7372     7372              
=============================================
+ Hits           13744    13923     +179     
+ Misses         11034    10881     -153     
+ Partials        1122     1104      -18     
Impacted Files Coverage Δ
gsa/src/web/pages/extras/cvsscalculatorpage.js 94.73% <ø> (ø)
gsa/src/web/pages/extras/feedstatuspage.js 97.67% <ø> (ø)
gsa/src/web/pages/extras/trashcanpage.js 3.27% <ø> (ø)
gsa/src/web/pages/permissions/multipledialog.js 15.78% <ø> (ø)
gsa/src/web/pages/radius/dialog.js 66.66% <ø> (ø)
gsa/src/web/pages/results/details.js 47.12% <ø> (+40.22%) ⬆️
gsa/src/web/pages/start/page.js 51.23% <ø> (ø)
gsa/src/web/pages/users/detailspage.js 33.33% <ø> (ø)
gsa/src/web/pages/users/row.js 26.66% <ø> (ø)
gsa/src/gmp/models/user.js 100.00% <100.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 037864b...e8396ed. Read the comment docs.

@bjoernricks bjoernricks merged commit 7b97bb0 into greenbone:gsa-20.08 May 21, 2021
swaterkamp added a commit that referenced this pull request May 25, 2021
Fix setting whether to include related resources in new permissions (backport #2931)
swaterkamp added a commit that referenced this pull request May 25, 2021
Fix setting whether to include related resources in new permissions (backport #2931)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port-to-main Use mergifiy to port PR to master port-to-stable Use mergifiy to port PR to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants