Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new message type for the case that a CPE or a CVE cannot be found. #3749

Merged

Conversation

jhelmold
Copy link
Member

@jhelmold jhelmold commented Jun 8, 2023

What

Added a new message type for the case that a CPE or a CVE cannot be found. This is supposed to improve the understanding.

Why

This is a small improvement.

References

GEA-207

Checklist

Tested locally on my development system.

  • Tests

Added a new message type for the case that a CPE or a CVE cannot
be found.
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Conventional Commits Report

😢 No conventional commits found.

👉 Learn more about the conventional commits usage at Greenbone.

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #3749 (463468f) into main (c0da6db) will decrease coverage by 0.02%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##             main    #3749      +/-   ##
==========================================
- Coverage   60.10%   60.09%   -0.02%     
==========================================
  Files        1021     1023       +2     
  Lines       25132    25143      +11     
  Branches     7423     7427       +4     
==========================================
+ Hits        15105    15109       +4     
- Misses       9087     9092       +5     
- Partials      940      942       +2     
Impacted Files Coverage Δ
src/web/entity/page.js 76.36% <20.00%> (-5.64%) ⬇️
src/web/components/error/message.js 40.00% <40.00%> (ø)
src/web/components/error/messagecontainer.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jhelmold jhelmold marked this pull request as ready for review June 8, 2023 16:01
@jhelmold jhelmold requested a review from a team as a code owner June 8, 2023 16:01
@jhelmold jhelmold added the port-to-stable Use mergifiy to port PR to stable label Jun 9, 2023
Copy link
Member

@timopollmeier timopollmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message box looks good to me but it would be nice if you could add German translations for the new text to public/locales/gsa-de.json.

…' of github.com:greenbone/gsa into GEA-207_Adjust_GSA_error_message_if_CPE_cannot_be_found
@timopollmeier timopollmeier merged commit 44c6ea6 into main Jun 14, 2023
8 of 10 checks passed
@timopollmeier timopollmeier deleted the GEA-207_Adjust_GSA_error_message_if_CPE_cannot_be_found branch June 14, 2023 12:59
@timopollmeier
Copy link
Member

@Mergifyio backport stable

@mergify
Copy link

mergify bot commented Jun 14, 2023

backport stable

❌ No backport have been created

  • Backport to branch stable failed

Git reported the following error:

error: commit 463468fd8a4d94fff40a360f1ab71519799bd220 is a merge but no -m option was given.
fatal: cherry-pick failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port-to-stable Use mergifiy to port PR to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants