Add function to get an osp scan status. #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnicola
added
work in progress
bjoernricks
previously approved these changes
Aug 26, 2019
There was a problem hiding this comment.
Looks good to me. Maybe @mattmundell may take an additional look.
mattmundell
requested changes
Aug 26, 2019
|
Spotted a little typo. And the patch looks OK, but I would rather see us using the _opt_t style interface in new functions. See osp_start_scan_ext for an example. This gives us flexibility in the future to extend the function without changing the args. |
jjnicola
force-pushed
the
osp-get-status
branch
from
d6de25c
to
d2884d6
Compare
mattmundell
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.