Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solution method to nvti. #283

Merged
merged 7 commits into from
Nov 8, 2019

Conversation

janowagner
Copy link
Member

The solution method is handled analog to the solution type
and allows for a more refined formal solution definition.

@janowagner janowagner marked this pull request as ready for review October 31, 2019 18:06
@janowagner janowagner mentioned this pull request Oct 31, 2019
2 tasks
Copy link
Contributor

@mattmundell mattmundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests. There are some simple examples in nvti_tests.c.

base/nvti.c Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mattmundell mattmundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes are good. Still want to see a couple tests though.

The solution method is handled analog to the solution type
and allows for a more refined formal solution definition.
Copy link
Contributor

@mattmundell mattmundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! Just a small ordering cleanup.

base/nvti_tests.c Outdated Show resolved Hide resolved
@mattmundell mattmundell merged commit 8e0d899 into greenbone:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants