Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nvti_get_tag(). #285

Merged
merged 10 commits into from
Oct 25, 2019
Merged

Add nvti_get_tag(). #285

merged 10 commits into from
Oct 25, 2019

Conversation

janowagner
Copy link
Member

This adds a function to get a tag value
for a certain tag name.
The main intention is to avoid routines using nvti API
needing to know about the pipe separator syntax.

Copy link
Contributor

@mattmundell mattmundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added the first tests of this file in /pull/286. Would be great if you could merge that and then add a few unit test to this PR.

base/nvti.c Outdated Show resolved Hide resolved
This adds a function to get a tag value
for a certain tag name.
The main intention is to avoid routines using nvti API
needing to know about the pipe separator syntax.
jjnicola
jjnicola previously approved these changes Oct 24, 2019
base/nvti.c Outdated Show resolved Hide resolved
@jjnicola jjnicola self-requested a review October 24, 2019 07:44
@jjnicola jjnicola dismissed their stale review October 24, 2019 07:46

Change requested

Copy link
Member

@jjnicola jjnicola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment

base/nvti_tests.c Show resolved Hide resolved
base/nvti.c Outdated Show resolved Hide resolved
Co-Authored-By: Juan José Nicola <jjnicola@gmail.com>
@mattmundell mattmundell merged commit a76de64 into greenbone:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants