-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nvti_get_tag(). #285
Merged
Merged
Add nvti_get_tag(). #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2019
mattmundell
requested changes
Oct 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added the first tests of this file in /pull/286. Would be great if you could merge that and then add a few unit test to this PR.
This adds a function to get a tag value for a certain tag name. The main intention is to avoid routines using nvti API needing to know about the pipe separator syntax.
janowagner
force-pushed
the
resolve_tags
branch
from
October 23, 2019 19:56
09a9a37
to
67d5d9d
Compare
jjnicola
previously approved these changes
Oct 24, 2019
jjnicola
requested changes
Oct 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment
Co-Authored-By: Juan José Nicola <jjnicola@gmail.com>
jjnicola
requested changes
Oct 25, 2019
Co-Authored-By: Juan José Nicola <jjnicola@gmail.com>
jjnicola
approved these changes
Oct 25, 2019
mattmundell
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a function to get a tag value
for a certain tag name.
The main intention is to avoid routines using nvti API
needing to know about the pipe separator syntax.