add unit tests and small changes for port range functions #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit tets for port list. Allow whitespace after 'T' or 'U'. Previously ':' had to follow immidiately after.
Unit tests for port_in_port_ranges(). Make valid port range string a requirement for this function. Allow whitespace after 'T' or 'U'. Previously ':' had to follow immidiately after.
mattmundell
requested changes
Apr 20, 2020
Add unit tests for port_in_port_ranges(). Add some more standard port lists for validate_port_range() too. Add changelog entry.
ArnoStiefvater
force-pushed
the
ports-unit-tests
branch
from
a11c6e1
to
7e06b59
Compare
ArnoStiefvater
force-pushed
the
ports-unit-tests
branch
from
7e06b59
to
371c5be
Compare
mattmundell
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests for port range functions validate_port_range(), port_range_ranges() and port_in_port_ranges().
Allow white-space after port type specifier for consistency (it is allowed everywhere else too).
Log warning when invalid port range is used in port_range_ranges() and add assert.
Checklist: