Send the correct num of dead hosts to ospd-openvas #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnoStiefvater
force-pushed
the
send-correct-numbe-of-dead-hosts
branch
2 times, most recently
from
c77e637
to
680271d
Compare
When we reach the max_scan_hosts limit we do not send the true number of dead hosts. The number needed by ospd-opevas for calculating the correct progress bar and not ending a scan in the interrupted state is calculated by subtracting the number max_scan_hosts from the number of target hosts if max_scan_hosts was reached.
ArnoStiefvater
force-pushed
the
send-correct-numbe-of-dead-hosts
branch
from
680271d
to
72fe1d6
Compare
jjnicola
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we reach the max_scan_hosts limit we do not need send the true number of dead hosts.
The number needed by ospd-opevas for calculating the correct progress bar and not ending a scan in the interrupted state is calculated by subtracting the number of max_scan_hosts and alive hosts from the number of target hosts.
Checklist: