Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gcc errors #477

Merged
merged 3 commits into from
Jun 30, 2021
Merged

Fix gcc errors #477

merged 3 commits into from
Jun 30, 2021

Conversation

tuxmaster5000
Copy link
Contributor

Fix for
#476

jjnicola
jjnicola previously approved these changes Apr 16, 2021
View reviewed changes
@jjnicola jjnicola dismissed their stale review April 16, 2021 10:50

Targeted to a wrong branch

@jjnicola jjnicola self-requested a review April 16, 2021 10:50
jjnicola
jjnicola previously requested changes Apr 16, 2021
View reviewed changes
Copy link
Member

@jjnicola jjnicola left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Could you change please the target branch to gvm-libs-21.04 instead of master ?

@tuxmaster5000 tuxmaster5000 requested a review from a team as a code owner June 28, 2021 14:03
@y0urself y0urself changed the base branch from master to gvm-libs-21.04 June 30, 2021 08:29
@y0urself y0urself changed the base branch from gvm-libs-21.04 to master June 30, 2021 08:29
@y0urself y0urself added backport-to-oldstable This pull request will be backported to the 20.08 branch backport-to-stable This pull request will be backported to the 21.04 branch labels Jun 30, 2021
@y0urself y0urself enabled auto-merge June 30, 2021 08:30
@y0urself y0urself dismissed jjnicola’s stale review June 30, 2021 08:31

Backporting should also work.

@y0urself y0urself merged commit edf0b51 into greenbone:master Jun 30, 2021
This was referenced Jun 30, 2021
Merged
Closed
y0urself added a commit that referenced this pull request Jun 30, 2021
@y0urself
Merge pull request #546 from greenbone/mergify/bp/gvm-libs-21.04/pr-477
bfb8e95 
Fix gcc errors (backport #477)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0urself y0urself y0urself approved these changes

@jjnicola jjnicola jjnicola left review comments

@ArnoStiefvater ArnoStiefvater Awaiting requested review from ArnoStiefvater

@timopollmeier timopollmeier Awaiting requested review from timopollmeier

Assignees
No one assigned
Labels
backport-to-oldstable This pull request will be backported to the 20.08 branch backport-to-stable This pull request will be backported to the 21.04 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tuxmaster5000 @jjnicola @y0urself