Fix: Use source size copying strings with memcpy #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timopollmeier
added
the
backport-to-stable
timopollmeier
force-pushed
the
fix-uses-of-memcpy
branch
from
61f5f30
to
d42f47c
Compare
timopollmeier
removed
the
backport-to-stable
nichtsfrei
approved these changes
Mar 21, 2023
nichtsfrei
added
the
backport-to-stable
timopollmeier
added a commit
that referenced
this pull request
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When copying strings with memcpy in places where strncpy was used before, use the size of the source string instead of the destination size.
Why
Using the destination size can cause errors if it is larger than the source size.
References
Checklist