Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versioning #150

Merged
merged 3 commits into from Feb 7, 2019
Merged

Update versioning #150

merged 3 commits into from Feb 7, 2019

Conversation

bjoernricks
Copy link
Member

  • Don't require python-gvm to be installed for running setup.py
  • Use PEP 440 compliant version

Don't use get_version_string from python-gvm anymore and really really
return a PEP 440 compliant version number.

Fixes #143
Ensure gvmtools always gets loaded from the current path when running
setup.py.
@bjoernricks bjoernricks requested review from davidak, wiegandm and a team February 7, 2019 08:27
@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #150 into master will decrease coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #150      +/-   ##
=========================================
- Coverage    1.66%   1.65%   -0.01%     
=========================================
  Files           5       5              
  Lines         240     241       +1     
=========================================
  Hits            4       4              
- Misses        236     237       +1
Impacted Files Coverage Δ
gvmtools/__init__.py 66.66% <33.33%> (-13.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be5246...728f114. Read the comment docs.

@bjoernricks bjoernricks merged commit 234bd46 into greenbone:master Feb 7, 2019
@bjoernricks bjoernricks deleted the update-versioning branch February 7, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants