Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gvm script #152

Merged
merged 8 commits into from
Feb 28, 2019
Merged

Gvm script #152

merged 8 commits into from
Feb 28, 2019

Conversation

bjoernricks
Copy link
Contributor

Add new CLI gvm-script to run gmp scripts. Running scripts only should be removed from gvm-pyshell in future.

@bjoernricks bjoernricks requested review from davidak, wiegandm and a team February 26, 2019 09:07
@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #152 into master will decrease coverage by 4.22%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
- Coverage   40.89%   36.66%   -4.23%     
==========================================
  Files           4        5       +1     
  Lines         269      300      +31     
==========================================
  Hits          110      110              
- Misses        159      190      +31
Impacted Files Coverage Δ
gvmtools/helper.py 0% <0%> (ø) ⬆️
gvmtools/pyshell.py 0% <0%> (ø) ⬆️
gvmtools/script.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e4502...3afecdf. Read the comment docs.

Copy link
Member

@wiegandm wiegandm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest a small rewording of the output, otherwise the PR looks good to me.

gvmtools/pyshell.py Show resolved Hide resolved
@bjoernricks bjoernricks merged commit 5ca4d8f into greenbone:master Feb 28, 2019
@bjoernricks bjoernricks deleted the gvm-script branch February 28, 2019 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants