Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve scripts #365

Merged
merged 9 commits into from Jan 8, 2021
Merged

Improve scripts #365

merged 9 commits into from Jan 8, 2021

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Jan 7, 2021 •
edited

What:

Why:

How:

  • e.g. replace quit() by sys.exit() (because of bad practice)
  • remove code duplicates and added these reusable functions to the helper.py class.
    • Added tests for these

Checklist:

@y0urself y0urself requested a review from a team as a code owner January 7, 2021 15:54
nichtsfrei
nichtsfrei approved these changes Jan 8, 2021
View reviewed changes
gvmtools/helper.py Outdated Show resolved Hide resolved
@y0urself y0urself merged commit e9b7077 into greenbone:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nichtsfrei nichtsfrei nichtsfrei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@y0urself @nichtsfrei