Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added systemd, logrotate and config files. #1240

Merged
merged 8 commits into from Aug 11, 2020
Merged

Added systemd, logrotate and config files. #1240

merged 8 commits into from Aug 11, 2020

Conversation

cfi-gb
Copy link
Member

@cfi-gb cfi-gb commented Aug 10, 2020

To have at least some basic examples how the config and startup of the daemon should look like.

Also used the default socket path configurable after #1244

Replaces #142, mainly taken from greenbone/gsa#1486, greenbone/gsa#1514 and greenbone/gsa#2328

Related: greenbone/ospd-openvas#312, greenbone/gsa#2375

Checklist:

@cfi-gb cfi-gb requested a review from a team August 10, 2020 08:36
@cfi-gb cfi-gb mentioned this pull request Aug 10, 2020
config/gvmd.service.in Outdated Show resolved Hide resolved
config/gvmd.service.in Outdated Show resolved Hide resolved
bjoernricks
bjoernricks previously approved these changes Aug 10, 2020
Copy link
Member

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side. --osp-vt-update should not be necessary with only one ospd-openvas scanner but if a user has two running instance on different sockets it is better to include that param.

@cfi-gb
Copy link
Member Author

cfi-gb commented Aug 11, 2020

@greenbone/gvm-dev :
Not sure why the build is now failing after 9077a93. Seems that this somehow is referring to a non-existent gvmd.default:

CMake Error at config/cmake_install.cmake:56 (file):
  file INSTALL cannot find "/root/project/config/gvmd.default".
Call Stack (most recent call first):
  cmake_install.cmake:426 (include)

Compiling the project locally worked out as expected and the gvmd.default is correctly configured, are there any outdated artifacts left on Circle CI?

@cfi-gb
Copy link
Member Author

cfi-gb commented Aug 11, 2020

Ah, nvm. Found it: 4e6a608

@bjoernricks bjoernricks merged commit 738cb18 into greenbone:gvmd-20.08 Aug 11, 2020
@cfi-gb cfi-gb deleted the add_systemd_files branch August 11, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants