Fix: Convert severity & qod to numbers in check_osp_result_exists #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
timopollmeier
added
backport-to-stable
When checking if a result is a duplicate, the severity and QoD are converted to a double and int respectively so invalid values do not cause SQL errors. This addresses a problem where results with no QoD would cause errors.
timopollmeier
force-pushed
the
fix-check_osp_result_exists-numbers
branch
from
c90da5f
to
581fe4e
Compare
jhelmold
approved these changes
Jul 14, 2023
nichtsfrei
approved these changes
Jul 14, 2023
timopollmeier
added a commit
that referenced
this pull request
Jul 14, 2023
Fix: Convert severity & qod to numbers in check_osp_result_exists (backport #2044)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When checking if a result is a duplicate, the severity and QoD are converted to a double and int respectively so invalid values do not cause SQL errors.
Why
This addresses a problem where results with no QoD would cause errors.
References
Fixes #2006
GEA-250
GEA-256