Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: Differentiate between audit and scan reports #2125

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Change: Differentiate between audit and scan reports #2125

wants to merge 11 commits into from

Conversation

a-h-abdelsalam
Copy link
Contributor

@a-h-abdelsalam a-h-abdelsalam commented Jan 15, 2024 •
edited

What

  • Add usage_type to GMP command get_reports command to differentiate between audit and scan reports. In the response, compliance / compliance count is now used for audit reports instead of severity / result count.
  • GMP command get_results now includes compliance state for the results.
  • Sub-types (audit, audit_report and policy) are allowed for tags.
  • Filters are allowed for audit_report.

Why

To be used in a dedicated view for compliance audit reports in GSA.

References

GEA-397

@github-actions GitHub Actions
Copy link

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

This was referenced Jan 19, 2024
Draft
Draft
@a-h-abdelsalam a-h-abdelsalam force-pushed the differentiate-audit-and-scan-reports branch from ea470fc to 6a22cd8 Compare February 14, 2024 13:54
@a-h-abdelsalam a-h-abdelsalam marked this pull request as ready for review February 14, 2024 15:43
timopollmeier
timopollmeier reviewed Feb 15, 2024
View reviewed changes
src/manage_pg.c Outdated Show resolved Hide resolved
src/manage_pg.c Outdated Show resolved Hide resolved
src/manage_sql.c Show resolved Hide resolved
src/manage_sql.c Show resolved Hide resolved
@a-h-abdelsalam a-h-abdelsalam force-pushed the differentiate-audit-and-scan-reports branch from ed4bb3d to a1cb092 Compare February 20, 2024 10:20
@a-h-abdelsalam a-h-abdelsalam marked this pull request as draft February 20, 2024 10:20
@a-h-abdelsalam a-h-abdelsalam marked this pull request as ready for review February 20, 2024 11:05
@a-h-abdelsalam a-h-abdelsalam marked this pull request as draft March 13, 2024 16:46
@mattmundell mattmundell mentioned this pull request Mar 13, 2024
Closed
@a-h-abdelsalam a-h-abdelsalam force-pushed the differentiate-audit-and-scan-reports branch from 38bea61 to de0bdca Compare April 4, 2024 16:12
@a-h-abdelsalam a-h-abdelsalam marked this pull request as ready for review April 4, 2024 16:59
@a-h-abdelsalam a-h-abdelsalam marked this pull request as draft April 5, 2024 07:54
@a-h-abdelsalam a-h-abdelsalam force-pushed the differentiate-audit-and-scan-reports branch from de0bdca to bd4a6e8 Compare May 13, 2024 11:42
@a-h-abdelsalam a-h-abdelsalam force-pushed the differentiate-audit-and-scan-reports branch from bd4a6e8 to 80637fe Compare June 11, 2024 08:42
@a-h-abdelsalam
Change: Differentiate between audit and scan reports
cc9811b 
- usage_type can now be used with get_reports GMP command to get audit/scan reports separately.
- compliance / compliance count is now used for audit reports instead of severity / result count.
@a-h-abdelsalam
Refactor printing the XML for a report host
57e052c
@a-h-abdelsalam
Add compliance per host to XML report
6cd5211
@a-h-abdelsalam
Fix the where clause for reports to check for a filter given by ID
84336f0
@a-h-abdelsalam
Fix compliance filter term not applied in get_aggregates
63e9cfc
@a-h-abdelsalam
Tags can now work with audit_reports
f4f7adc 
- Added audit reports filer and dashboard configuration to settings.
@a-h-abdelsalam
Tags applied by filter on scan reports exclude audit reports.
671d10a
@a-h-abdelsalam
Exclude audit reports from scan tags filter when removing resources
6ec6d8e
@a-h-abdelsalam
Tags can now be used with audit tasks and compliance policies
adffe73
@a-h-abdelsalam
Updated GMP documentation
3353293
@a-h-abdelsalam a-h-abdelsalam force-pushed the differentiate-audit-and-scan-reports branch from 80637fe to 6214202 Compare June 11, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timopollmeier timopollmeier timopollmeier approved these changes

@mattmundell mattmundell Awaiting requested review from mattmundell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@a-h-abdelsalam @timopollmeier