Fix the authentication used by the Start Task alert #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The static was added in 680e132 'Mark static functions and variables', but this should not be static because it refers to the variable defined in manage.c. This was preventing the Start Task alert from running.
In particular this resets the username, otherwise AUTHENTICATE in internally forked GMP connections will append the username to the existing username. This is not actually used by the forked process as the authentication always succeeds, but at least the username is right now.
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
======================================
Coverage 93.3% 93.3%
======================================
Files 58 58
Lines 5499 5499
======================================
Hits 5131 5131
Misses 368 368
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 58 58
Lines 5503 5503
=======================================
Hits 5133 5133
Misses 370 370
Continue to review full report at Codecov.
|
timopollmeier
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.