Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return early when there is no content of filter fields #70

Merged
merged 2 commits into from
May 22, 2024

Conversation

endyApina
Copy link
Contributor

What

Return early and do not attempt to build conditional query if filter object is not empty but the filter fields are empty.

Why

Invalid query string when there is an empty filter field

References

https://jira.greenbone.net/browse/VTI-145

Checklist

  • Tests

@endyApina endyApina requested review from a team as code owners May 22, 2024 10:11
Copy link

github-actions bot commented May 22, 2024

Conventional Commits Report

Type Number
Changed 2

🚀 Conventional commits found.

@endyApina endyApina added bug Something isn't working minor release Set label to create a minor release labels May 22, 2024
@endyApina endyApina merged commit c331281 into main May 22, 2024
8 checks passed
@endyApina endyApina deleted the fix-postgres-add-filter-query branch May 22, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor release Set label to create a minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants