Change: openvasd: stream responses #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichtsfrei
force-pushed
the
openvasd-reduce-buffering
branch
4 times, most recently
from
d519026
to
8ec7217
Compare
nichtsfrei
changed the title
nichtsfrei
force-pushed
the
openvasd-reduce-buffering
branch
2 times, most recently
from
64b9044
to
06a7a24
Compare
Instead of collecting various sources before combining and changing them this will get the source, return an iterator so that the using calls can decide if they want to combine various iterator before map them into the target struct. This does reduce the memory footprint when gathering nvt data from e.g. redis. Additionally openvasd imports the whole feed instead of just nvts. To get meta information call: ``` curl localhost:3000/vts?information=true ```
nichtsfrei
force-pushed
the
openvasd-reduce-buffering
branch
from
06a7a24
to
f6396e9
Compare
jjnicola
added a commit
that referenced
this pull request
Feb 12, 2024
This module gets a scan config and prepare the data to be stored in redis as openvas-scanner expected. The data is stored in redis as well. For that, a new module openvas_redis was added as well, which adds an implements the RedisHelper struct. Depends on #1566
2 tasks
jjnicola
added a commit
that referenced
this pull request
Feb 12, 2024
This module gets a scan config and prepare the data to be stored in redis as openvas-scanner expected. The data is stored in redis as well. For that, a new module openvas_redis was added as well, which adds an implements the RedisHelper struct. Depends on #1566
jjnicola
added a commit
that referenced
this pull request
Feb 12, 2024
This module gets a scan config and prepare the data to be stored in redis as openvas-scanner expected. The data is stored in redis as well. For that, a new module openvas_redis was added as well, which adds an implements the RedisHelper struct. Depends on #1566
jjnicola
added a commit
that referenced
this pull request
Feb 13, 2024
This module gets a scan config and prepare the data to be stored in redis as openvas-scanner expected. The data is stored in redis as well. For that, a new module openvas_redis was added as well, which adds an implements the RedisHelper struct. Depends on #1566
jjnicola
requested changes
Feb 14, 2024
nichtsfrei
force-pushed
the
openvasd-reduce-buffering
branch
from
09f93b7
to
671653a
Compare
jjnicola
previously approved these changes
Feb 14, 2024
Kraemii
previously approved these changes
Feb 14, 2024
jjnicola
approved these changes
Feb 14, 2024
Kraemii
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of collecting various sources before combining and changing them
this will get the source, return an iterator so that the using calls can
decide if they want to combine various iterator before map them into the
target struct.
This does reduce the memory footprint when gathering nvt data from e.g.
redis.
Additionally openvasd imports the whole feed instead of just nvts.
To get meta information call:
Jira: SC-1018