Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: builtin NASL hash functions #1616

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Add: builtin NASL hash functions #1616

merged 4 commits into from
Apr 16, 2024

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Apr 5, 2024

What:
Add: builtin NASL hash functions
Jira: SC-1049

Why:

How:
scannerctl execute /home/jnicola/my_nasl/hash.nasl 

display(hexstr(MD2("hola mundo")));
display(hexstr(MD4("hola mundo")));
display(hexstr(MD5("hola mundo")));
display(hexstr(SHA1("hola mundo")));
display(hexstr(SHA256("hola mundo")));
display(hexstr(SHA512("hola mundo")));
display(hexstr(RIPEMD160("hola mundo")));

Checklist:

  • Tests
  • PR merge commit message adjusted

@jjnicola jjnicola requested a review from a team as a code owner April 5, 2024 13:13
@jjnicola jjnicola force-pushed the hash-digest branch 5 times, most recently from 4c4e5a5 to fa91e85 Compare April 8, 2024 09:06
@jjnicola
Copy link
Member Author

jjnicola commented Apr 8, 2024

MIT/Apache2.0 is non-spdx compliant. I have created the PR rustls/tokio-rustls#62 for fixing the license issue.

@jjnicola jjnicola enabled auto-merge (squash) April 9, 2024 05:28
Kraemii
Kraemii requested changes Apr 9, 2024
View reviewed changes
rust/nasl-builtin-cryptographic/src/hash.rs Outdated Show resolved Hide resolved
rust/nasl-builtin-cryptographic/src/hash.rs Show resolved Hide resolved
rust/nasl-builtin-cryptographic/src/md5sum Outdated Show resolved Hide resolved
rust/nasl-builtin-cryptographic/tests/hash.rs Outdated Show resolved Hide resolved
@jjnicola
Copy link
Member Author

rustls/rustls#1893

@jjnicola jjnicola requested a review from Kraemii April 10, 2024 11:05
Kraemii
Kraemii previously approved these changes Apr 11, 2024
View reviewed changes
@jjnicola jjnicola requested a review from Kraemii April 16, 2024 08:14
@jjnicola jjnicola merged commit 5575c0f into main Apr 16, 2024
16 of 18 checks passed
@jjnicola jjnicola deleted the hash-digest branch April 16, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nichtsfrei nichtsfrei nichtsfrei approved these changes

@Kraemii Kraemii Kraemii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jjnicola @nichtsfrei @Kraemii