Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop network scan #493

Merged
merged 21 commits into from
May 7, 2020
Merged

Drop network scan #493

merged 21 commits into from
May 7, 2020

Commits on May 6, 2020

  1. Disable network_scan. 

    This disables the network scan mode. Neither activating
in openvas.conf nor via the scan configuration will be possible
anymore.
    @janowagner
    janowagner committed May 6, 2020
    Configuration menu
    Copy the full SHA
    fb042c5 View commit details
    Browse the repository at this point in the history

  2. Remove do_network_scan code paths 

    do_network_scan is always false. So, remove
and code path that requires it to be true
and finally remove this variable itself.
    @janowagner
    janowagner committed May 6, 2020
    Configuration menu
    Copy the full SHA
    fb3f66d View commit details
    Browse the repository at this point in the history

  3. Remove code paths for network_phase. 

    The variable network_phase is always FALSE.
So, removing any code path that requires the variable
to be true and finally remove the variable itself.
    @janowagner
    janowagner committed May 6, 2020
    Configuration menu
    Copy the full SHA
    0a16345 View commit details
    Browse the repository at this point in the history

  4. Fix indenting. 

    This change only fixes intending format from
previous commit.
    @janowagner
    janowagner committed May 6, 2020
    Configuration menu
    Copy the full SHA
    8a5a277 View commit details
    Browse the repository at this point in the history

  5. Drop unused parameter of plugins_scheduler_init() 

    The parameter "only_network" is always false.
So, drop the respective code path from
function plugins_scheduler_init() and finally
the parameter itself.
    @janowagner
    janowagner committed May 6, 2020
    Configuration menu
    Copy the full SHA
    fba7d72 View commit details
    Browse the repository at this point in the history

  6. Drop code paths for nss = "busy" 

    The network scan status is never set to "busy",
so the respective code paths can be removed.
This includes the removal of function network_scan_status().
    @janowagner
    janowagner committed May 6, 2020
    Configuration menu
    Copy the full SHA
    cd6b6fd View commit details
    Browse the repository at this point in the history

  7. Drop code path for NSS_BUSY 

    NSS_BUSY is never set, so removing the code
paths for it and finally any occurance of it.
    @janowagner
    janowagner committed May 6, 2020
    Configuration menu
    Copy the full SHA
    020271c View commit details
    Browse the repository at this point in the history

  8. Drop code path for NSS_DONE. 

    NSS_DONE is never the case, so remove any code path
for this case and finally NSS_DONE itself.
    @janowagner
    janowagner committed May 6, 2020
    Configuration menu
    Copy the full SHA
    373f4a8 View commit details
    Browse the repository at this point in the history

  9. Remove now unused function kb_duplicate().

    @janowagner
    janowagner committed May 6, 2020
    Configuration menu
    Copy the full SHA
    bdd3a63 View commit details
    Browse the repository at this point in the history

  10. Drop code path for NSS_NONE 

    NSS_NONE is not explicitly used anymore,
so removing the code paths. This finally also
allows to remove the then unused enum type net_scan_status.
    @janowagner
    janowagner committed May 6, 2020
    Configuration menu
    Copy the full SHA
    dce5d39 View commit details
    Browse the repository at this point in the history

  11. Remove code path for network_scan. 

    The variable network_scan is always false.
So, remove the code paths and finally the variable itself.
    @janowagner
    janowagner committed May 6, 2020
    Configuration menu
    Copy the full SHA
    6a19609 View commit details
    Browse the repository at this point in the history

  12. No need to set default for network_scan 

    Because it is not used anymore.
    @janowagner
    janowagner committed May 6, 2020
    Configuration menu
    Copy the full SHA
    0f57734 View commit details
    Browse the repository at this point in the history

  13. Remove handling of now unused net_kb

    @janowagner
    janowagner committed May 6, 2020
    Configuration menu
    Copy the full SHA
    51616c1 View commit details
    Browse the repository at this point in the history

  14. Resolve handle_client() into scanner_thread() 

    After the removal of net_kb, handle_client()
consists only of a few lines and is called only
from a single place.
    @janowagner
    janowagner committed May 6, 2020
    Configuration menu
    Copy the full SHA
    eb01d9e View commit details
    Browse the repository at this point in the history

  15. Drop builtin_nmap module. 

    This module was only supporting the network scan mode
and thus can be removed entirely now.
The NASL API method "plugin_run_nmap" is used
only in a single NASL file in the feed for network
mode to run NSE and it is even protected by "defined_func".
    @janowagner
    janowagner committed May 6, 2020
    Configuration menu
    Copy the full SHA
    b65d830 View commit details
    Browse the repository at this point in the history

  16. Remove any code path about network_targets 

    Since it is not used anymore, it can be removed entirely.
The NASL API function "network_targets" is used only
by a single NVT and only for the condition of network scan
phase which is never true.
    @janowagner
    janowagner committed May 6, 2020
    Configuration menu
    Copy the full SHA
    622ce8e View commit details
    Browse the repository at this point in the history

  17. Remove any code path about scan_phase. 

    The NASL API function scan_phase() is not needed
anymore and any related code is removed.
    @janowagner
    janowagner committed May 6, 2020
    Configuration menu
    Copy the full SHA
    d367454 View commit details
    Browse the repository at this point in the history

  18. Remove global network_scan_status variable. 

    It is not needed/used anymore.
    @janowagner
    janowagner committed May 6, 2020
    Configuration menu
    Copy the full SHA
    12fc100 View commit details
    Browse the repository at this point in the history

  19. Remove note on network scan from docs.

    @janowagner
    janowagner committed May 6, 2020
    Configuration menu
    Copy the full SHA
    5b55bd9 View commit details
    Browse the repository at this point in the history

  20. Fix formatting.

    @janowagner
    janowagner committed May 6, 2020
    Configuration menu
    Copy the full SHA
    f84b41f View commit details
    Browse the repository at this point in the history

  21. Add changelog entry.

    @janowagner
    janowagner committed May 6, 2020
    Configuration menu
    Copy the full SHA
    c467fae View commit details
    Browse the repository at this point in the history