Fix interrupted scans (backport #832) #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Fix SC-177 On some cases, the parallel scan is disabled and, the max_running_processes variable is set to 1, while the current number of running process is grether than 1. Therefore, condition in the while loop are not satisfied and never wait for free slot. At the end, the process table is full, and this produced the host scan process to stop, because not free slot for a new process. (cherry picked from commit dd3e46d)
(cherry picked from commit 17b38c0)
This allows to handle the the error in a different way as for fork() issues (-1). (cherry picked from commit 57c867b)
Because ERR_CANT_FORK should be used when there are resource issues, and when the system is not being able to fork a new processes. ERR_NO_FREE_SLOT is an internal error of the host scan process, which could be in most cases a temporal issue. We don't stop the host scan process. We just try again until the process table has a free slot. (cherry picked from commit ad3bd82)
(cherry picked from commit 0dbce72)
(cherry picked from commit 61c76a4)
Improve messages and docstrings. Set warning log level instead of debug log level for plugin_launch error messages. (cherry picked from commit b43156e)
jjnicola
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #832 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/