Fix: issue related to a fix in popt v1.19 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the new popt release, a memory leak was fixed. Wmic relais into the leak to get the command line options (hostname, namespace, etc). Once the leak is fixed, the command line options are not available anymore. This patch makes a deep copy of the options and now are available again. Also, adds a new file with structure definition and functions to init and free the structure with the program arguments, necessary not only for wmic, but also for other libs related to wmi (wmireg, wmirsop).
Kraemii
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
With the new popt release, a memory leak was fixed. Wmic relais into the leak to get the command line options (hostname, namespace, etc). Once the leak is fixed, the command line options are not available anymore.
This patch makes a deep copy of the options and now are available again.
Also, adds a new file with structure definition and functions to init and free the structure with the program arguments, necessary not only for wmic, but also for other libs related to wmi (wmireg, wmirsop).
Close #77
Close greenbone/openvas-scanner#1491
Jira: SC-923
Why
wmi didn't work. This patch solve it.
References
Checklist