Drop network scan #493
Merged
Drop network scan #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janowagner
force-pushed
the
drop_network_scan
branch
from
8286cec
to
7ed3bb9
Compare
|
@janowagner : can you elaborate why this is being removed? |
|
@hazcod because it got never beyond of the experimental status and isn't supported at all. |
janowagner
force-pushed
the
drop_network_scan
branch
from
7ed3bb9
to
efd505f
Compare
This disables the network scan mode. Neither activating in openvas.conf nor via the scan configuration will be possible anymore.
do_network_scan is always false. So, remove and code path that requires it to be true and finally remove this variable itself.
The variable network_phase is always FALSE. So, removing any code path that requires the variable to be true and finally remove the variable itself.
This change only fixes intending format from previous commit.
The parameter "only_network" is always false. So, drop the respective code path from function plugins_scheduler_init() and finally the parameter itself.
The network scan status is never set to "busy", so the respective code paths can be removed. This includes the removal of function network_scan_status().
NSS_BUSY is never set, so removing the code paths for it and finally any occurance of it.
NSS_DONE is never the case, so remove any code path for this case and finally NSS_DONE itself.
NSS_NONE is not explicitly used anymore, so removing the code paths. This finally also allows to remove the then unused enum type net_scan_status.
The variable network_scan is always false. So, remove the code paths and finally the variable itself.
Because it is not used anymore.
After the removal of net_kb, handle_client() consists only of a few lines and is called only from a single place.
This module was only supporting the network scan mode and thus can be removed entirely now. The NASL API method "plugin_run_nmap" is used only in a single NASL file in the feed for network mode to run NSE and it is even protected by "defined_func".
Since it is not used anymore, it can be removed entirely. The NASL API function "network_targets" is used only by a single NVT and only for the condition of network scan phase which is never true.
The NASL API function scan_phase() is not needed anymore and any related code is removed.
It is not needed/used anymore.
janowagner
force-pushed
the
drop_network_scan
branch
from
efd505f
to
c467fae
Compare
jjnicola
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the network scan mode and all related code.
The experimental feature of the network scan mode of OpenVAS was developed to force scanning steps into parallel processing, especially for wrapped external tools like Nmap. The concept did not work out as expected but it helped to find advanced concepts. Wrapping tools in VTs did not deliver the desired seamless integration into the scan process. Greenbone rather started into micro-service architecture to bring bottlenecks into parallel seamless integration. Now it is time to finally drop the network scan mode.