Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Typing. #162

Merged
merged 4 commits into from
Nov 21, 2019
Merged

More Typing. #162

merged 4 commits into from
Nov 21, 2019

Conversation

jjnicola
Copy link
Member

  • Add typing to db.py
  • Improve typing in nvticache.py

@codecov
Copy link

codecov bot commented Nov 21, 2019

Codecov Report

Merging #162 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   71.28%   71.31%   +0.02%     
==========================================
  Files           4        4              
  Lines        1010     1011       +1     
==========================================
+ Hits          720      721       +1     
  Misses        290      290
Impacted Files Coverage Δ
ospd_openvas/nvticache.py 96.33% <100%> (-0.07%) ⬇️
ospd_openvas/db.py 98.98% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbb7ea6...15e0c52. Read the comment docs.

Copy link
Member

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. I am not sure about some Optional returns because the haven't been mentioned in the docstrings but I guess you have checked them :-)

@jjnicola
Copy link
Member Author

Looks very good. I am not sure about some Optional returns because the haven't been mentioned in the docstrings but I guess you have checked them :-)

The returns were indeed checked. If a key is empty or it does not exists, redis return None. Therefore someones are optional.

@jjnicola jjnicola merged commit 0057a11 into greenbone:master Nov 21, 2019
@jjnicola jjnicola deleted the db-typing branch November 21, 2019 10:46
ArnoStiefvater pushed a commit to ArnoStiefvater/ospd-openvas that referenced this pull request Oct 25, 2021
Improve error handling when stop a scan.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants