-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More Typing. #162
More Typing. #162
Conversation
jjnicola
commented
Nov 21, 2019
- Add typing to db.py
- Improve typing in nvticache.py
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
==========================================
+ Coverage 71.28% 71.31% +0.02%
==========================================
Files 4 4
Lines 1010 1011 +1
==========================================
+ Hits 720 721 +1
Misses 290 290
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. I am not sure about some Optional returns because the haven't been mentioned in the docstrings but I guess you have checked them :-)
The returns were indeed checked. If a key is empty or it does not exists, redis return None. Therefore someones are optional. |
Improve error handling when stop a scan.