-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the handling of the vts dictionary according to the new vts dictionary in a data manager. #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
- Coverage 72.11% 72.04% -0.08%
==========================================
Files 4 4
Lines 1040 1048 +8
==========================================
+ Hits 750 755 +5
- Misses 290 293 +3
Continue to review full report at Codecov.
|
jjnicola
removed
the
Work in progress
Waiting for Feature Specification validation.
label
Dec 9, 2019
This avoid an expencive interprocess communication between the scan process and the vts data manager, which reduce considerably the time to load the plugins and their preferences in redis.
This avoids to consult the vts dictionary many times for each result, which is expensive in terms of time specially when the scan has many host details results.
jjnicola
changed the title
Set self.vts to None when there is a pending feed.
Update the handling of the vts dictionary according to the new vts dictionary in a data manager.
Dec 9, 2019
bjoernricks
approved these changes
Dec 9, 2019
jjnicola
removed
the
Work in progress
Waiting for Feature Specification validation.
label
Dec 9, 2019
ArnoStiefvater
pushed a commit
to ArnoStiefvater/ospd-openvas
that referenced
this pull request
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on PR greenbone/ospd#191