Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for alive test settings. #182

Merged
merged 8 commits into from
Jan 20, 2020

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Jan 17, 2020

Depends on PR greenbone/ospd#194. After merging ospd pr 194, the Pipefile.lock must be updated.

@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #182 into master will increase coverage by 0.12%.
The diff coverage is 73.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage    71.9%   72.02%   +0.12%     
==========================================
  Files           4        4              
  Lines        1050     1101      +51     
==========================================
+ Hits          755      793      +38     
- Misses        295      308      +13
Impacted Files Coverage Δ
ospd_openvas/daemon.py 61.05% <73.68%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12fec04...408e73e. Read the comment docs.

@jjnicola jjnicola marked this pull request as ready for review January 17, 2020 13:40
@jjnicola jjnicola added the Work in progress Waiting for Feature Specification validation. label Jan 17, 2020
ospd_openvas/daemon.py Outdated Show resolved Hide resolved
Also define the ping host OID.
@bjoernricks bjoernricks merged commit 9fcf84c into greenbone:master Jan 20, 2020
@jjnicola jjnicola deleted the alive-test branch January 20, 2020 08:19
@jjnicola jjnicola removed the Work in progress Waiting for Feature Specification validation. label Jan 20, 2020
ArnoStiefvater pushed a commit to ArnoStiefvater/ospd-openvas that referenced this pull request Oct 25, 2021
Remove from exclude_host list the hosts passed as finished too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants