Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing scan preferences. #184

Merged
merged 7 commits into from
Jan 24, 2020
Merged

Conversation

jjnicola
Copy link
Member

No description provided.

@cfi-gb
Copy link
Member

cfi-gb commented Jan 23, 2020

@jjnicola jjnicola marked this pull request as ready for review January 23, 2020 15:52
@jjnicola jjnicola added the Work in progress Waiting for Feature Specification validation. label Jan 23, 2020
@jjnicola jjnicola removed the Work in progress Waiting for Feature Specification validation. label Jan 24, 2020
@jjnicola jjnicola requested review from bjoernricks and removed request for bjoernricks January 24, 2020 07:51
CHANGELOG.md Outdated
@@ -20,6 +20,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

### Fixed
- Check vt_aux for None before trying to access it. [#177](https://github.com/greenbone/ospd-openvas/pull/177)
- Fix missing scan preferences. [#184](https://github.com/greenbone/ospd-openvas/pull/184)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is better to add two entries. One in Added for mentioning the new preferences and one in Removed section mentioning the deleted ones.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks 👍

@bjoernricks bjoernricks merged commit 9e70dbe into greenbone:master Jan 24, 2020
@jjnicola jjnicola deleted the vhost-opt branch January 24, 2020 08:53
ArnoStiefvater pushed a commit to ArnoStiefvater/ospd-openvas that referenced this pull request Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants