Improve nvt feed check. #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compare the amount of filename keys and nvt keys in redis with the amount of oid loaded in memory.
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
- Coverage 75.08% 75.06% -0.03%
==========================================
Files 5 5
Lines 1160 1175 +15
==========================================
+ Hits 871 882 +11
- Misses 289 293 +4
Continue to review full report at Codecov.
|
bjoernricks
approved these changes
Feb 14, 2020
| - Set reverse lookup options. [#185](https://github.com/greenbone/ospd-openvas/pull/185) | ||
|
|
||
| - Set reverse lookup options. [#185](https://gitub.com/greenbone/ospd-openvas/pull/185) | ||
| - Check if the amount of vts in redis is coherent. [#195](https://github.com/greenbone/ospd-openvas/pull/195) |
There was a problem hiding this comment.
Suggested change
| - Check if the amount of vts in redis is coherent. [#195](https://github.com/greenbone/ospd-openvas/pull/195) | |
| - Check if the amount of vts in redis is coherent. [#195](https://github.com/greenbone/ospd-openvas/pull/195) | |
cfi-gb
reviewed
Feb 15, 2020
CHANGELOG.md
Outdated
| @@ -11,8 +11,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). | |||
| - Add typing to daemon.py, nvticache.py and db.py. [#161](https://github.com/greenbone/ospd-openvas/pull/161)[#162](https://github.com/greenbone/ospd-openvas/pull/162)[#163](https://github.com/greenbone/ospd-openvas/pull/163) | |||
| - Add support for alive test settings. [#182](https://github.com/greenbone/ospd-openvas/pull/182) | |||
| - Add missing scan preferences expand_vhosts and test_empty_vhost. [#184](https://github.com/greenbone/ospd-openvas/pull/184) | |||
| - Set reverse lookup options. [#185](https://github.com/greenbone/ospd-openvas/pull/185) | |||
|
|
|||
| - Set reverse lookup options. [#185](https://gitub.com/greenbone/ospd-openvas/pull/185) | |||
There was a problem hiding this comment.
Suggested change
| - Set reverse lookup options. [#185](https://gitub.com/greenbone/ospd-openvas/pull/185) | |
| - Set reverse lookup options. [#185](https://github.com/greenbone/ospd-openvas/pull/185) |
Not sure what happened here, especially as the link was correct previously.
ArnoStiefvater
pushed a commit
to ArnoStiefvater/ospd-openvas
that referenced
this pull request
Oct 25, 2021
Accept reverse_lookup_only and reverse_lookup_unify target's options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare the amount of filename keys and nvt keys in redis with the amount of oid loaded in memory.