Don't release the vts explicitly. #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method was removed from ospd. And the vts are popped when they are get. Also, update tests, because the data manager is initialized when the daemon is run, and not when a scan is created.
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
==========================================
- Coverage 82.33% 82.26% -0.07%
==========================================
Files 9 9
Lines 1455 1455
==========================================
- Hits 1198 1197 -1
- Misses 257 258 +1
Continue to review full report at Codecov.
|
bjoernricks
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method was removed from ospd. And the vts are popped when they
are get.