Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle denied hosts. #263

Merged
merged 2 commits into from
May 25, 2020
Merged

Handle denied hosts. #263

merged 2 commits into from
May 25, 2020

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented May 20, 2020

Denied hosts are not scanned by openvas, but a child process to check if
it is allowed/denied is started. No ip address for this hosts is
written in the kb and therefore must be handled in a special way,
The error message received from openvas contains the ip address
and it is taken from here.

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #263 into master will increase coverage by 0.04%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
+ Coverage   82.43%   82.48%   +0.04%     
==========================================
  Files           9        9              
  Lines        1469     1473       +4     
==========================================
+ Hits         1211     1215       +4     
  Misses        258      258              
Impacted Files Coverage Δ
ospd_openvas/daemon.py 61.84% <71.42%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af3f261...c0d4d64. Read the comment docs.

@jjnicola jjnicola marked this pull request as ready for review May 20, 2020 14:35
Copy link
Member

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just typos

CHANGELOG.md Outdated Show resolved Hide resolved
ospd_openvas/daemon.py Outdated Show resolved Hide resolved
Denied host are not scanned by openvas, but a child process to check if
it is allowed/denied is started. No ip address for this hosts is
written in kb and therefore most be handled in a special way,
The error message received from openvas contains the ip address
and it taken from here.
@bjoernricks bjoernricks merged commit 8083764 into greenbone:master May 25, 2020
@jjnicola jjnicola deleted the deny-host branch June 24, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants