Improvements for fetching results from redis. #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, waits 1 second. This speeds up the fetch of results if it is supposed to be more results and don't stress redis unnecessary.
This reduce the amount of queries to redis.
bjoernricks
reviewed
Jul 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
==========================================
- Coverage 82.80% 81.99% -0.81%
==========================================
Files 9 9
Lines 1477 1505 +28
==========================================
+ Hits 1223 1234 +11
- Misses 254 271 +17
Continue to review full report at Codecov.
|
bjoernricks
requested changes
Jul 9, 2020
ospd_openvas/daemon.py
Outdated
| got_results = False | ||
| if not got_results: | ||
| time.sleep(1) | ||
| time.sleep(0.05) |
There was a problem hiding this comment.
Shouldn't be this in an else branch?
Suggested change
| time.sleep(0.05) | |
| else: | |
| time.sleep(0.05) |
bjoernricks
approved these changes
Jul 9, 2020
ArnoStiefvater
pushed a commit
to ArnoStiefvater/ospd-openvas
that referenced
this pull request
Oct 25, 2021
Extend results with optional URI parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.