Allow to change encoding used to store a key-value pair in redis. #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ospd-openvas-20.08 #294 +/- ##
======================================================
- Coverage 82.71% 81.90% -0.81%
======================================================
Files 9 9
Lines 1481 1509 +28
======================================================
+ Hits 1225 1236 +11
- Misses 256 273 +17
Continue to review full report at Codecov.
|
cfi-gb
reviewed
Jul 18, 2020
ospd_openvas/db.py
Outdated
| def _add_single_item( | ||
| self, name: str, values: Iterable, utf8_enc: Optional[bool] = False | ||
| ): | ||
| ''' Changing the encoding format of an existent redis context |
There was a problem hiding this comment.
Suggested change
| ''' Changing the encoding format of an existent redis context | |
| ''' Changing the encoding format of an existing redis context |
ospd_openvas/db.py
Outdated
| self, openvas_scan_id: str, preferences: Iterable | ||
| ): | ||
| ''' Force the usage of the utf-8 encoding, since some credentials | ||
| contains specials chars not supported by latin-1 enconding. ''' |
There was a problem hiding this comment.
Suggested change
| contains specials chars not supported by latin-1 enconding. ''' | |
| contain special chars not supported by latin-1 encoding. ''' |
ospd_openvas/db.py
Outdated
| """ Connect to redis to the given database or to the default db 0 . | ||
|
|
||
| Arguments: | ||
| dbnum: The db number to connect to. | ||
| encoding: The enconding to be used to read and write. |
There was a problem hiding this comment.
Suggested change
| encoding: The enconding to be used to read and write. | |
| encoding: The encoding to be used to read and write. |
Sorry, missed this one on the first go.
ArnoStiefvater
previously approved these changes
Jul 21, 2020
Some credentials contains utf-8 chars, while the standard for openvas is latin-1. This allows to change the encoding when storing credentials.
ArnoStiefvater
approved these changes
Jul 22, 2020
ArnoStiefvater
pushed a commit
to ArnoStiefvater/ospd-openvas
that referenced
this pull request
Oct 25, 2021
Update readme and changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some credentials contains utf-8 chars, while the default for openvas
is latin-1. This allows to change the encoding when storing credentials.