Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optimize_test preference #302

Merged

Conversation

ArnoStiefvater
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #302 into ospd-openvas-20.08 will decrease coverage by 0.82%.
The diff coverage is 50.00%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           ospd-openvas-20.08     #302      +/-   ##
======================================================
- Coverage               82.71%   81.89%   -0.83%     
======================================================
  Files                       9        9              
  Lines                    1481     1513      +32     
======================================================
+ Hits                     1225     1239      +14     
- Misses                    256      274      +18     
Impacted Files Coverage Δ
ospd_openvas/daemon.py 62.12% <35.00%> (-0.78%) ⬇️
ospd_openvas/preferencehandler.py 87.15% <50.00%> (+0.04%) ⬆️
ospd_openvas/db.py 96.24% <55.00%> (-3.36%) ⬇️
ospd_openvas/lock.py 85.96% <100.00%> (+0.25%) ⬆️
ospd_openvas/openvas.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 410b1b8...cd93d4e. Read the comment docs.

ospd_openvas/daemon.py Outdated Show resolved Hide resolved
ospd_openvas/daemon.py Show resolved Hide resolved
Copy link
Member

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit to me

@bjoernricks bjoernricks merged commit 9a54a74 into greenbone:ospd-openvas-20.08 Aug 3, 2020
@cfi-gb
Copy link
Member

cfi-gb commented Aug 3, 2020

I can confirm that the "optimize_test" value is now showing up as yes/no on NASL side again.

ArnoStiefvater pushed a commit to ArnoStiefvater/ospd-openvas that referenced this pull request Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants