Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for empty vts preferences list #340

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

jjnicola
Copy link
Member

What:
Check for empty vts preferences list before trying to add an empty list into redis.

Why:
Adding an empty list is not allowed and raises an exception. Not it is check. This can happen for small scan configs with less VTs without preferences.

How:
I find this issue running a small scan config with only one selected VT "ssh_authorization.nasl"

Checklist:

@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #340 into ospd-openvas-20.08 will decrease coverage by 0.87%.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           ospd-openvas-20.08     #340      +/-   ##
======================================================
- Coverage               82.71%   81.84%   -0.88%     
======================================================
  Files                       9        9              
  Lines                    1481     1520      +39     
======================================================
+ Hits                     1225     1244      +19     
- Misses                    256      276      +20     
Impacted Files Coverage Δ
ospd_openvas/__version__.py 100.00% <ø> (ø)
ospd_openvas/daemon.py 62.01% <ø> (-0.90%) ⬇️
ospd_openvas/db.py 96.24% <ø> (-3.36%) ⬇️
ospd_openvas/lock.py 85.96% <ø> (+0.25%) ⬆️
ospd_openvas/nvticache.py 98.49% <ø> (+0.01%) ⬆️
ospd_openvas/openvas.py 100.00% <ø> (ø)
ospd_openvas/preferencehandler.py 87.93% <ø> (+0.82%) ⬆️
ospd_openvas/vthelper.py 86.61% <ø> (-2.10%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c12f15c...0516423. Read the comment docs.

@jjnicola jjnicola merged commit 69f452c into greenbone:ospd-openvas-20.08 Sep 29, 2020
@jjnicola jjnicola deleted the check-empty-list branch September 29, 2020 12:53
ArnoStiefvater pushed a commit to ArnoStiefvater/ospd-openvas that referenced this pull request Oct 25, 2021
Add more information and problem resolution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants