Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve structure #450

Merged
merged 8 commits into from
Jul 8, 2021
Merged

Improve structure #450

merged 8 commits into from
Jul 8, 2021

Conversation

Kraemii
Copy link
Member

@Kraemii Kraemii commented Jun 28, 2021

What:
Improving the overall structure of ospd-openvas.
Currently changed the following:

  • Scan-loop structure
  • Zombie-process handling
  • Stopping a scan

Depends on: greenbone/ospd#432

Why:
There are many bugs and interrupted scan issues which can't be reproduced. On top of that the ospd-openvas code is hardly readable and need some improvements to make it easier to hunt bugs and work on issues.

How:
Just testing some scan configs and the stop scan feature to make sure everything is working as expected.

TODO:

  • Adjust Unittests

Checklist:

@Kraemii Kraemii mentioned this pull request Jun 28, 2021
2 tasks
@Kraemii Kraemii changed the title Improve structure2 Improve structure Jun 28, 2021
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #450 (cf46955) into master (4489242) will decrease coverage by 0.00%.
The diff coverage is 24.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
- Coverage   80.30%   80.30%   -0.01%     
==========================================
  Files          10       10              
  Lines        1681     1665      -16     
==========================================
- Hits         1350     1337      -13     
+ Misses        331      328       -3     
Impacted Files Coverage Δ
ospd_openvas/db.py 97.05% <0.00%> (ø)
ospd_openvas/daemon.py 65.07% <17.77%> (-0.55%) ⬇️
ospd_openvas/openvas.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4489242...cf46955. Read the comment docs.

@Kraemii Kraemii marked this pull request as ready for review July 8, 2021 08:35
@Kraemii Kraemii requested a review from a team as a code owner July 8, 2021 08:35
@Kraemii Kraemii force-pushed the improve-structure2 branch 4 times, most recently from 1b090b4 to cf46955 Compare July 8, 2021 09:33
@Kraemii Kraemii merged commit 170f948 into greenbone:master Jul 8, 2021
@Kraemii Kraemii mentioned this pull request Jul 8, 2021
2 tasks
@Kraemii Kraemii deleted the improve-structure2 branch July 12, 2021 14:16
ArnoStiefvater pushed a commit to ArnoStiefvater/ospd-openvas that referenced this pull request Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants