Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Resume tasks - part 3 #103

Merged
merged 5 commits into from May 7, 2019
Merged

Resume tasks - part 3 #103

merged 5 commits into from May 7, 2019

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented May 7, 2019

Add get_hosts_finished().
Add get_scan_finished_hosts()
Add get_scan_unfinished_hosts().
Improve docstring.

Add get_scan_finished_hosts()
Add get_scan_unfinished_hosts().
Update the results list.
Improve docstring.
@jjnicola jjnicola requested review from bjoernricks and a team May 7, 2019 12:27
@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #103 into master will increase coverage by 0.6%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #103     +/-   ##
=========================================
+ Coverage   67.89%   68.49%   +0.6%     
=========================================
  Files           8        8             
  Lines        1573     1584     +11     
=========================================
+ Hits         1068     1085     +17     
+ Misses        505      499      -6
Impacted Files Coverage Δ
ospd/misc.py 70.37% <100%> (+1.44%) ⬆️
ospd/ospd.py 66.54% <75%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cef7731...4b971f8. Read the comment docs.

bjoernricks
bjoernricks previously approved these changes May 7, 2019
Copy link
Member

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always tests for the new methods would have been nice

@jjnicola jjnicola merged commit 93c8281 into greenbone:master May 7, 2019
@jjnicola jjnicola deleted the resume-tasks branch May 7, 2019 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants