This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Improve get_vts cmd response, sending the vts piece by piece. #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernricks
suggested changes
Feb 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
+ Coverage 72.6% 72.64% +0.04%
==========================================
Files 16 16
Lines 2022 2058 +36
==========================================
+ Hits 1468 1495 +27
- Misses 554 563 +9
Continue to review full report at Codecov.
|
bjoernricks
suggested changes
Feb 10, 2020
…ts in encoded strings representing an xml piece, to be sent to the client.
Before the response was a single huge xml element in a string, made before sending which caused a huge memory consumption. Now the amount of memory used for this cmd is quite smaller.
Using this generartor reduce the amount of memory used for the get_vts response
Don't do a copy. Instead use a generator. This reduce considerably the amount of memory used during the filtered vts list.
jjnicola
requested review from
bjoernricks
and removed request for
bjoernricks
bjoernricks
approved these changes
Feb 11, 2020
|
I think you have addressed all my comments already 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the response was a single huge xml element in a string, made before sending
which caused a huge memory consumption. Now the amount of memory used for this cmd
is quite smaller.