This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Show progress as int #269
Merged
Show progress as int #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #269 +/- ##
==========================================
+ Coverage 74.51% 74.56% +0.05%
==========================================
Files 21 21
Lines 2315 2320 +5
==========================================
+ Hits 1725 1730 +5
Misses 590 590
Continue to review full report at Codecov.
|
bjoernricks
reviewed
May 13, 2020
ospd/ospd.py
Outdated
| self, | ||
| scan_id: str, | ||
| host: str = None, | ||
| progress: Union[float, int] = None, |
There was a problem hiding this comment.
Why should be a float still allowed?
There was a problem hiding this comment.
This comes from the wrapper. It depends on the wrapper implementation. Currently ospd-openvas sends a float value
bjoernricks
reviewed
May 13, 2020
ospd/scan.py
Outdated
| hosts = self.scans_table[scan_id]['target_progress'] | ||
| if hosts: | ||
| for host, progress in hosts.items(): | ||
| hosts[host] = int(progress) |
There was a problem hiding this comment.
Shouldn't we ensure that progress is already an int in the scans table?
bjoernricks
approved these changes
May 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.