Simplify start_scan() #275
Conversation
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
==========================================
+ Coverage 74.56% 74.57% +0.01%
==========================================
Files 21 21
Lines 2335 2332 -3
==========================================
- Hits 1741 1739 -2
+ Misses 594 593 -1
Continue to review full report at Codecov.
|
ospd/scan.py
Outdated
| @@ -378,6 +378,10 @@ def get_target_options(self, scan_id: str): | |||
| """ | |||
| return self.scans_table[scan_id]['target'].get('options') | |||
|
|
|||
| def get_target(self, scan_id: str) -> Dict: | |||
There was a problem hiding this comment.
Would be nice to add the concrete Dict type here like Dict[str, str]. Not sure what key and value types are used here.
There was a problem hiding this comment.
Btw. same for the other methods like get_vts below
jjnicola
force-pushed
the
scan-collection
branch
2 times, most recently
from
674bc2c
to
4eb3089
Compare
Also, improve typing
ospd/scan.py
Outdated
| def get_vts(self, scan_id: str) -> Dict: | ||
| def get_target( | ||
| self, scan_id: str | ||
| ) -> Dict[str, Union[str, Dict[str, Union[str, Dict[str, str]]]]]: |
There was a problem hiding this comment.
All target information is there. Credentials (for different services), target options (alive tests method and reverse_lookup options), port list, hosts (to be scanned, finished and excluded).
I removed this method, because is not necessary anymore. I have just simplified the start_scan() method.
No description provided.