This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Fix scan progress in which all hosts are dead or excluded. #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ospd-20.08 #295 +/- ##
==============================================
+ Coverage 74.56% 74.72% +0.15%
==============================================
Files 23 23
Lines 2540 2544 +4
==============================================
+ Hits 1894 1901 +7
+ Misses 646 643 -3
Continue to review full report at Codecov.
|
bjoernricks
reviewed
Jul 1, 2020
ospd/ospd.py
Outdated
| @@ -619,13 +620,17 @@ def sort_host_finished( | |||
| scan_id, finished_hosts | |||
| ) | |||
|
|
|||
| def set_target_progress(self, scan_id: str): | |||
There was a problem hiding this comment.
Doesn't this method set the scan progress instead of the target progress? Currently I find the term target a bit confusing here. Could there be several targets in a scan?
bjoernricks
approved these changes
Jul 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.