This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Don't iterate directly over the scans table, as it can change during the iteration. #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnoStiefvater
previously approved these changes
Jul 24, 2020
…the iteration. The scans table is accessed by different processes and the iterated dictionary can change it size.
Codecov Report
@@ Coverage Diff @@
## ospd-20.08 #304 +/- ##
==============================================
- Coverage 74.69% 74.50% -0.19%
==============================================
Files 23 23
Lines 2545 2550 +5
==============================================
- Hits 1901 1900 -1
- Misses 644 650 +6
Continue to review full report at Codecov.
|
ArnoStiefvater
approved these changes
Jul 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scans table is accessed by different processes and the iterated dictionary can
change it size.
The given case was that a new task is being queued (add info in the scans table) at same time a task is being taken from the queue to be started (both process access the scan table). But this will solve issues like a finished scan being removed from the scans table during a scans_table iteration.