Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Remove py3.5 and py3.6 support and deprecated methods. #316

Merged
merged 7 commits into from
Aug 17, 2020

Conversation

jjnicola
Copy link
Member

No description provided.

@bjoernricks
Copy link
Contributor

The linter is complaining about some unused imports. You can raise the minimum Python version to 3.7 if you want. I don't see a reason why we should support Python 3.6. But that's up to you.

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #316 into master will increase coverage by 0.18%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
+ Coverage   73.35%   73.54%   +0.18%     
==========================================
  Files          23       23              
  Lines        2560     2529      -31     
==========================================
- Hits         1878     1860      -18     
+ Misses        682      669      -13     
Impacted Files Coverage Δ
ospd/logger.py 0.00% <ø> (ø)
ospd/server.py 31.41% <0.00%> (+0.39%) ⬆️
ospd/vts.py 97.16% <ø> (+0.90%) ⬆️
ospd/ospd.py 71.15% <100.00%> (+0.01%) ⬆️
ospd/parser.py 91.66% <100.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 922de26...3b843ce. Read the comment docs.

@jjnicola jjnicola changed the title Remove python3.5 support and deprecated methods. Remove python v3.5 and v3.6 support and deprecated methods. Aug 17, 2020
@jjnicola jjnicola requested review from bjoernricks and removed request for bjoernricks August 17, 2020 12:27
@jjnicola jjnicola changed the title Remove python v3.5 and v3.6 support and deprecated methods. Remove py3.5 and py3.6 support and deprecated methods. Aug 17, 2020
@bjoernricks bjoernricks merged commit d10835a into greenbone:master Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants