Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Use better defaults for file paths and permissions #429

Merged
merged 2 commits into from
Jul 1, 2021

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Jul 1, 2021

What:

  • /var/run is just a symlink to /run nowadays.
  • Allow user and group to access to socket by default. This allows for
    querying data from osp in a multi-user setup more easily.
  • Move pid file within /run/ospd
  • There is no /usr/var directory by default. Therefore change the path
    to the certs to something that makes sense

Why:

How:

Checklist:

* /var/run is just a symlink to /run nowadays.
* Allow user and group to access to socket by default. This allows for
  querying data from osp in a multi-user setup more easily.
* Move pid file within /run/ospd
* There is no /usr/var directory by default. Therefore change the path
  to the certs to something that makes sense
@bjoernricks bjoernricks added backport-to-stable This pull request will be backported to the stable branch backport-to-main This pull request will be backported to the master branch labels Jul 1, 2021
@bjoernricks bjoernricks marked this pull request as ready for review July 1, 2021 10:02
@bjoernricks bjoernricks requested a review from a team as a code owner July 1, 2021 10:02
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #429 (352d01e) into ospd-20.08 (4bfb08d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           ospd-20.08     #429   +/-   ##
===========================================
  Coverage       74.35%   74.35%           
===========================================
  Files              23       23           
  Lines            2652     2652           
===========================================
  Hits             1972     1972           
  Misses            680      680           
Impacted Files Coverage Δ
ospd/parser.py 88.63% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bfb08d...352d01e. Read the comment docs.

@bjoernricks bjoernricks merged commit d23743a into ospd-20.08 Jul 1, 2021
@bjoernricks bjoernricks deleted the better-config-defaults branch July 1, 2021 10:15
bjoernricks added a commit that referenced this pull request Aug 5, 2021
Use better defaults for file paths and permissions (backport #429)
jjnicola added a commit that referenced this pull request Aug 12, 2021
Use better defaults for file paths and permissions (backport #429)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport-to-main This pull request will be backported to the master branch backport-to-stable This pull request will be backported to the stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants