Data transformation #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernricks
requested changes
Aug 17, 2020
bjoernricks
reviewed
Aug 17, 2020
| def test_parsing(xml): | ||
| under_test = XMLParser() | ||
| result = under_test.parse(xml) | ||
| assert result == {'data': {'a': 'b'}} |
There was a problem hiding this comment.
would be good to get additional tests for the normalization behavior too.
There was a problem hiding this comment.
The data normalization is done within gvmd.py; there is a different test for that:
tests/test_gvmd_scanreport_datatransformation.py
the xml parser just creates a dict representation of any xml so far
bjoernricks
reviewed
Aug 17, 2020
bjoernricks
reviewed
Aug 17, 2020
bjoernricks
reviewed
Aug 17, 2020
Co-authored-by: Björn Ricks <bjoern.ricks@gmail.com>
Co-authored-by: Björn Ricks <bjoern.ricks@gmail.com>
Co-authored-by: Björn Ricks <bjoern.ricks@gmail.com>
Co-authored-by: Björn Ricks <bjoern.ricks@gmail.com>
Co-authored-by: Björn Ricks <bjoern.ricks@gmail.com>
Co-authored-by: Björn Ricks <bjoern.ricks@gmail.com>
Co-authored-by: Björn Ricks <bjoern.ricks@gmail.com>
saberlynx
reviewed
Aug 18, 2020
bjoernricks
requested changes
Aug 18, 2020
Co-authored-by: Björn Ricks <bjoern.ricks@gmail.com>
Co-authored-by: Björn Ricks <bjoern.ricks@gmail.com>
Co-authored-by: Björn Ricks <bjoern.ricks@gmail.com>
bjoernricks
requested changes
Aug 18, 2020
bjoernricks
requested changes
Aug 18, 2020
Co-authored-by: Björn Ricks <bjoern.ricks@gmail.com>
bjoernricks
reviewed
Aug 18, 2020
bjoernricks
reviewed
Aug 18, 2020
Co-authored-by: Björn Ricks <bjoern.ricks@gmail.com>
bjoernricks
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: