[pontos-release] Fix signing #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The urls provided by the github api contain archives with git hashes as file paths. That's not the correct file. Therefore use the url also listed at the web pages. Hopefully they never break these urls.
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
==========================================
- Coverage 88.61% 88.41% -0.21%
==========================================
Files 11 11
Lines 817 820 +3
Branches 124 125 +1
==========================================
+ Hits 724 725 +1
- Misses 64 65 +1
- Partials 29 30 +1
Continue to review full report at Codecov.
|
y0urself
previously approved these changes
Jun 24, 2021
y0urself
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Use same urls as in the browser for downloading the to be signed files.
Why:
Generated signatures are wrong.
How:
Uploaded new signatures for gvm-libs 21.4.1 and tested the asc file for the tarball.
Checklist: