Refactor PontosVersionCommand #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop name parameter because it is mostly unused. Require to pass pyproject_toml_path and version_file_path to the VersionCommand constructor.
Add a generic implementation of the get_current_version method to VersionCommand class. It tries to import the module specified by version_file_path and returns the __version__ variable from this module.
Don't hardcode version_file_path and pyproject_toml_path in PontosVersionCommand. Instead try to load the pyproject.toml file and read the version file path from a [tool.pontos.version] section.
This will allow to show, verify and update the version more easily.
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
==========================================
- Coverage 91.26% 90.22% -1.05%
==========================================
Files 14 15 +1
Lines 378 409 +31
==========================================
+ Hits 345 369 +24
- Misses 33 40 +7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't require to implement an own VersionCommand for the library/tool using pontos for handling version information. Instead allow to specify the version file in the
pyproject.toml.Checklist: