Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: typing in pontos/nvd #673

Merged
merged 2 commits into from Jun 22, 2023
Merged

Fix: typing in pontos/nvd #673

merged 2 commits into from Jun 22, 2023

Conversation

Tacire
Copy link
Contributor

@Tacire Tacire commented Mar 9, 2023

What

Fixed typing in pontos/nvd (checked using poetry run mypy pontos/nvd)

Why

To prepare pontos for posible automatic typing checks in the future

References

DEVOPS-354

Checklist

  • Tests

@Tacire Tacire marked this pull request as ready for review March 9, 2023 11:59
@Tacire Tacire requested a review from a team as a code owner March 9, 2023 11:59
@Tacire Tacire marked this pull request as draft March 9, 2023 12:06
@Tacire Tacire marked this pull request as ready for review March 10, 2023 12:26
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #673 (b45368b) into main (7380f7c) will decrease coverage by 0.27%.
The diff coverage is 93.75%.

❗ Current head b45368b differs from pull request most recent head 0a5c98e. Consider uploading reports for the commit 0a5c98e to get more accurate results

@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
- Coverage   89.71%   89.45%   -0.27%     
==========================================
  Files          82       79       -3     
  Lines        5389     4968     -421     
  Branches      759      665      -94     
==========================================
- Hits         4835     4444     -391     
+ Misses        389      368      -21     
+ Partials      165      156       -9     
Impacted Files Coverage Δ
pontos/nvd/cpe/api.py 98.38% <92.30%> (-1.62%) ⬇️
pontos/nvd/cve/api.py 98.92% <93.33%> (-1.08%) ⬇️
pontos/nvd/api.py 96.36% <100.00%> (ø)

... and 26 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

y0urself
y0urself previously approved these changes Apr 5, 2023
@github-actions
Copy link

Conventional Commits Report

Type Number
Bug Fixes 2

🚀 Conventional commits found.

@y0urself y0urself merged commit a1a0f73 into main Jun 22, 2023
14 of 15 checks passed
@y0urself y0urself deleted the Tacire/typing-nvd branch June 22, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants